Skip to content

Commit

Permalink
[automate-2578] bump node version 10.15.2 -> 12.13.1 (#2579)
Browse files Browse the repository at this point in the history
* Reverting reference back to main path

Two previous PRs (#785 and #2267) updated plan.sh
in a couple projects to be specific to a node.js major version.
I now believe that was an unnecessary, and in fact, brittle change.
A node.js package newly installed in core-plans makes its way
to the "main branch" (https://bldr.habitat.sh/#/pkgs/core/node).
References should remain invariant to that location
so they do not need updating when node.js major versions change.

Signed-off-by: michael sorens <msorens@chef.io>

* automate-ui: Regenerate with new node version

Only change: added `optional` property to many packages.

$ npm install

> automate-ui@0.0.0 install /Users/msorens/code/go/src/github.com/chef/automate/components/automate-ui
> echo 'use `npm run install:ui-library` for old behaviour'; npm run copy-ui-lib

use `npm run install:ui-library` for old behaviour

> automate-ui@0.0.0 copy-ui-lib /Users/msorens/code/go/src/github.com/chef/automate/components/automate-ui
> npm run copy-ui-lib:library && npm run copy-ui-lib:fonts

> automate-ui@0.0.0 copy-ui-lib:library /Users/msorens/code/go/src/github.com/chef/automate/components/automate-ui
> cp -r ../chef-ui-library/dist/ src/assets/chef-ui-library

> automate-ui@0.0.0 copy-ui-lib:fonts /Users/msorens/code/go/src/github.com/chef/automate/components/automate-ui
> cp -r ../chef-ui-library/dist/collection/assets/fonts/ src/assets/fonts

audited 18030 packages in 44.608s
found 0 vulnerabilities

Signed-off-by: michael sorens <msorens@chef.io>

* chef-ui-library: Regenerate with new node version

Only change: added `optional` property to many packages.

$ npm install
audited 1748734 packages in 9.775s
found 16 vulnerabilities (3 moderate, 13 high)
  run `npm audit fix` to fix them, or `npm audit` for details

Signed-off-by: michael sorens <msorens@chef.io>

* automate-workflow-web: Regenerate with new node version

Only change: added `optional` property to many packages.

$ npm install

> fsevents@1.2.9 install /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/fsevents
> node install

node-pre-gyp WARN Using request for node-pre-gyp https download
[fsevents] Success: "/Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/fsevents/lib/binding/Release/node-v72-darwin-x64/fse.node" is installed via remote

> node-zopfli@2.1.3 install /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/node-zopfli
> prebuild-install --runtime napi || prebuild-install || node-gyp rebuild

> phantomjs-prebuilt@2.1.16 install /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/phantomjs-prebuilt
> node install.js

PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-macosx.zip
Saving to /var/folders/c0/dxv4vgb11ts_cvznblv5pvtm0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip
Receiving...
  [=======================================-] 98%
Received 16746K total.
Extracting zip contents
Removing /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/phantomjs-prebuilt/lib/phantom
Copying extracted folder /var/folders/c0/dxv4vgb11ts_cvznblv5pvtm0000gn/T/phantomjs/phantomjs-2.1.1-macosx.zip-extract-1577140037455/phantomjs-2.1.1-macosx -> /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/phantomjs-prebuilt/lib/phantom
Writing location.js file
Done. Phantomjs binary available at /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs

> node-sass@4.13.0 install /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/node-sass
> node scripts/install.js

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.13.0/darwin-x64-72_binding.node
Download complete
Binary saved to /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/node-sass/vendor/darwin-x64-72/binding.node
Caching binary to /Users/msorens/.npm/node-sass/4.13.0/darwin-x64-72_binding.node

> node-sass@4.13.0 postinstall /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/node-sass
> node scripts/build.js

Binary found at /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/node-sass/vendor/darwin-x64-72/binding.node
Testing binary
Binary is fine

> sauce-connect-launcher@0.12.0 postinstall /Users/msorens/code/go/src/github.com/chef/automate/components/automate-workflow-web/node_modules/sauce-connect-launcher
> node scripts/install.js

npm WARN The package font-awesome is included as both a dev and production dependency.

added 1166 packages from 1337 contributors and audited 6940 packages in 189.377s
found 66 vulnerabilities (22 low, 9 moderate, 35 high)
  run `npm audit fix` to fix them, or `npm audit` for details

Signed-off-by: michael sorens <msorens@chef.io>

* automate-ui: bump .nvmrc

Signed-off-by: michael sorens <msorens@chef.io>

* automate-workflow-web: bump .nvmrc

Signed-off-by: michael sorens <msorens@chef.io>

* chef-ui-library: bump .nvmrc

Signed-off-by: michael sorens <msorens@chef.io>
  • Loading branch information
msorens authored Jan 3, 2020
1 parent 7ae2f75 commit 22fb2fe
Show file tree
Hide file tree
Showing 9 changed files with 160 additions and 62 deletions.
2 changes: 1 addition & 1 deletion .studio/automate-ui
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ function _install_nodejs_from_nvmrc() {
fi

log_line "Installing NodeJS (v.$NODE_VERSION)"
OPTS="-b" install "core/node10/$NODE_VERSION" >/dev/null
OPTS="-b" install "core/node/$NODE_VERSION" >/dev/null

install_if_missing core/git git;
install_if_missing core/coreutils env;
Expand Down
2 changes: 1 addition & 1 deletion components/automate-ui/.nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
10.15.2
12.13.1
2 changes: 1 addition & 1 deletion components/automate-ui/habitat/plan.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pkg_deps=(
pkg_build_deps=(
core/git
core/make
core/node10/"$(cat "$PLAN_CONTEXT/../.nvmrc")"
core/node/"$(cat "$PLAN_CONTEXT/../.nvmrc")"
core/rsync
)
pkg_exports=(
Expand Down
Loading

0 comments on commit 22fb2fe

Please sign in to comment.