fixes certificate idempotentcy on chef 11 clients #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix looks good to me.. minor comment - should the new_resource var be changed to @new_resource? looks like both new_resource and @new_resource are being used. |
|
👍 other than the same minor nitpick as @chefsalim |
mwrock
force-pushed
the
idempotent_11
branch
from
1f7878d to
e832147
Compare
|
ok i changed the |
mwrock
added a commit
that referenced
this pull request
Nov 18, 2015
fixes certificate idempotentcy on chef 11 clients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #296