Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add functions to load buffers, streams & URLs in NodeJS #2857

Merged
merged 18 commits into from
Nov 28, 2022
Merged

feat: Add functions to load buffers, streams & URLs in NodeJS #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
514c9c4
feat: Add batteries included methods for Node
fb55 Oct 10, 2022
ff4561b
Update node.ts
fb55 Oct 14, 2022
2779ed3
Start writing tests
fb55 Nov 2, 2022
5c4bc88
Bump encoding-sniffer
fb55 Nov 4, 2022
00499b4
Handle mime types, work on getting streams going
fb55 Nov 7, 2022
944b201
Set the `baseURL`
fb55 Nov 7, 2022
8b4a3ec
Rename `request` to `fromURL`
fb55 Nov 7, 2022
61ba1a4
Add `fromURL` tests
fb55 Nov 8, 2022
357cf70
Add `accept` header
fb55 Nov 16, 2022
e136833
Add `loadBuffer`
fb55 Nov 21, 2022
81ed6ae
Add Node exports by default for Node ESM
fb55 Nov 21, 2022
58cd3a1
Close servers after tests
fb55 Nov 21, 2022
1b81b16
Allow inferred request options to be overwritten
fb55 Nov 22, 2022
5cb5cfd
Add documentation comments
fb55 Nov 22, 2022
73c174f
Add jsdom types for benchmarks
fb55 Nov 22, 2022
6e7dbf4
Update suite.ts
fb55 Nov 22, 2022
526f1a5
Update eslint-plugin-node to -n
fb55 Nov 22, 2022
ce9d283
Split comment
fb55 Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions benchmark/suite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import fs from 'fs';
import path from 'path';
import fs from 'node:fs';
import path from 'node:path';
import { Script } from 'node:vm';

import { Suite, Event } from 'benchmark';
// @ts-expect-error `jsdom` types currently collide with `parse5` types.
import { JSDOM } from 'jsdom';
import { Script } from 'vm';
import cheerio from '../lib/index.js';

const documentDir = path.join(__dirname, 'documents');
Expand Down Expand Up @@ -74,11 +73,9 @@ export default class Suites {

jQueryScript.runInContext(dom.getInternalVMContext());

const setupData: T = options.setup(dom.window.$);
const setupData: T = options.setup(dom.window['$']);

suite.add('jsdom', () => {
testFn(dom.window.$, setupData);
});
suite.add('jsdom', () => testFn(dom.window['$'], setupData));
suite.run();
}

Expand Down
Loading