Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper function for functions with similar functionality #1731

Closed
wants to merge 8 commits into from
Closed

Wrapper function for functions with similar functionality #1731

wants to merge 8 commits into from

Conversation

5saviahv
Copy link
Contributor

Wrapper function "_matcher" for functions with similar functionality.

  • It changes .parents function sorting (test shows strange sorting order)
  • it changes .siblings function matched elements (it matches same elements what jQuery [first example on their website] )

other functions work like before, simply repeating parts of the functions are kept in "wrapper" function

same as #1662

@5saviahv 5saviahv closed this May 9, 2021
fb55 added a commit that referenced this pull request Jun 6, 2021
@fb55 @5saviahv
refactor(traversing): Wrap shared behavior
394e6e9 
Revival of #1731

Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
@fb55 fb55 mentioned this pull request Jun 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@5saviahv