Issue #13809: Kill mutation ConfigurationLoader2

[Kevin222004]

Issue #13809: Kill mutation ConfigurationLoader2

Test

[romani]

Items

[romani]

Kevin requested help on my comments , we need to help him.

[romani]

your code is correct by it is really hard to understand why this works like this.

lets make test full functional.

<?xml version="1.0" encoding="UTF-8"?>

<!DOCTYPE module PUBLIC
    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
    "https://checkstyle.org/dtds/configuration_1_3.dtd">

<module name="Checker">
    <module name="TreeWalker">
        <module name="MemberName">
            <property name="severity" value="x${severity}"  default="ignore"/>
        </module>
    </module>
</module>
 

load this config as it is done at

checkstyle/src/test/java/com/puppycrawl/tools/checkstyle/ConfigurationLoaderTest.java

Line 81 in bd3a9bb

public void testResourceLoadConfiguration() throws Exception {

and confirm that property is set to default value.

[romani]

I updated code to required state

[romani]

Github, generate website

[github-actions]

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ceefdd6_2023152903/index.html

https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/ceefdd6_2023152903/config.html#

[rnveach]

Why can't this test be written in our normal format?

@romani Don't we require javadoc for custom tests?

[romani]

Whole test class is not using our general format. I still do not feel good to migrate this also to our general for modules format.

Tests are very similar to each other.

[rnveach]

I assume this is referring to property values with multiple expansions in a single property?

This needs to be expanded. In addition why don't we add an example?

[romani]

Not only multiple expansion, any .

[romani]

I thought about example, but it is not easy to explain and might be too technical, and looks like nobody dealing with this, so we found this nuance only during pitest.

I think we don't need to make our doc to be too much extended and hard to read.