-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #13809: Kill mutation in SuppressionCommentFilter #13833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin222004
commented
Oct 5, 2023
src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilter.java
Outdated
Show resolved
Hide resolved
33 tasks
rnveach
requested changes
Oct 5, 2023
src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilter.java
Outdated
Show resolved
Hide resolved
Kevin222004
force-pushed
the
SuppressionCommentFilter
branch
from
October 22, 2023 02:19
db41797
to
aa3d550
Compare
romani
requested changes
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
direction is good.
items:
src/test/java/com/puppycrawl/tools/checkstyle/filters/SuppressionCommentFilterTest.java
Outdated
Show resolved
Hide resolved
@Kevin222004 , let us know if you need more help to handle this PR . |
romani
force-pushed
the
SuppressionCommentFilter
branch
3 times, most recently
from
November 7, 2023 14:00
0cdb756
to
ec54435
Compare
romani
force-pushed
the
SuppressionCommentFilter
branch
from
November 7, 2023 14:20
ec54435
to
4d44d4a
Compare
romani
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok to merge
rnveach
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #13809: Kill mutation in SuppressionCommentFilter
Filters
https://checkstyle.sourceforge.io/filters/suppressioncommentfilter.html#SuppressionCommentFilter
Mutation
checkstyle/config/pitest-suppressions/pitest-filters-suppressions.xml
Lines 282 to 289 in 00f1780
Explaination
test added.
Modified test prooves that exception is happening: