Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criu swrk: return child error to caller #175

Merged
merged 1 commit into from
Jul 19, 2024

Commits on Jul 19, 2024

  1. criu swrk: return child error to caller

    In the podman CI we are seeing a weird flake during criu version
    detection[1]. The write to the socket just fails with broken pipe.
    The logical thing to assume here is that the child exited. However the
    current code never reports back the child error from wait. The cleanup
    error is now added to the returned error so the caller sees both.
    
    The output is not captured as this causes hangs when the fds are passed
    into child processes.
    
    As errors.Join is used from the std lib bump the minimum go version to
    1.20.
    
    [1] containers/podman#18856
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1c9f152 View commit details
    Browse the repository at this point in the history