images/inventory: add field for enabled plugins #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rst0git
force-pushed
the
inventory-plugins
branch
from
ecd6f4e
to
e17069d
Compare
rst0git
force-pushed
the
inventory-plugins
branch
from
e17069d
to
669e8a1
Compare
avagin
reviewed
Oct 3, 2024
avagin
reviewed
Oct 3, 2024
rst0git
force-pushed
the
inventory-plugins
branch
12 times, most recently
from
0d79239
to
278c174
Compare
rst0git
changed the title
avagin
reviewed
Oct 8, 2024
rst0git
force-pushed
the
inventory-plugins
branch
from
278c174
to
0caf28f
Compare
This patch extends the inventory image with a `plugins` field that contains an array of plugins which were used during checkpoint, for example, to save GPU state. In particular, the CUDA and AMDGPU plugins are added to this field only when the checkpoint contains GPU state. This allows to disable unnecessary plugins during restore, show appropriate error messages if required CRIU plugin are missing, and migrate a process that does not use GPU from a GPU-enabled system to CPU-only environment. We use the `optional plugins_entry` for backwards compatibility. This entry allows us to distinguish between *unset* and *missing* field: - When the field is missing, it indicates that the checkpoint was created with a previous version of CRIU, and all plugins should be *enabled* during restore. - When the field is empty, it indicates that no plugins were used during checkpointing. Thus, all plugins can be *disabled* during restore. Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git
force-pushed
the
inventory-plugins
branch
from
0caf28f
to
62238a4
Compare
avagin
reviewed
Oct 14, 2024
| if (!plugin_added_to_inventory) { | ||
| status = add_inventory_plugin(CR_PLUGIN_DESC.name); | ||
| if (status) | ||
| pr_err("Failed to add CUDA plugin to inventory image\n"); |
There was a problem hiding this comment.
should we return a non-zero code in this case?
|
I think we should introduce a test for this change. |
avagin
reviewed
Oct 14, 2024
| return true; /* backwards compatibility */ | ||
|
|
||
| if (n_inventory_plugins > 0) { | ||
| struct inventory_plugin *p, *tmp; |
There was a problem hiding this comment.
nit: add an empty line between declarations and the code block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the inventory image with a
pluginsfield that contains an array of names indicating which plugins were used during checkpointing, for example, to save GPU state. In particular, the CUDA and AMDGPU plugins are added to this field only when the checkpoint contains GPU state. This allows to disable unnecessary plugins during restore, show appropriate error messages if required CRIU plugins are missing, and migrate a process that does not use GPU from a GPU-enabled system to CPU-only environment.