Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename _DOMAIN to _URL in env vars for back-front homogeneity and more explicit name #721

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

Pascal-Delange
Copy link
Contributor

@Pascal-Delange Pascal-Delange commented Feb 28, 2025

Prerequisite for the PR checkmarble/marble#80, see link

@Pascal-Delange Pascal-Delange changed the title rename _DOMAIN to _URL in env vars for back-front homogeneity and mor… rename _DOMAIN to _URL in env vars for back-front homogeneity and more explicit name Mar 3, 2025
@Pascal-Delange Pascal-Delange marked this pull request as ready for review March 3, 2025 13:09
@Pascal-Delange Pascal-Delange force-pushed the pascal/breaking-change-env-var-rename branch 2 times, most recently from 899a8a8 to c38b5af Compare March 3, 2025 20:49
Copy link
Contributor

@ChibiBlasphem ChibiBlasphem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pascal-Delange Pascal-Delange force-pushed the pascal/breaking-change-env-var-rename branch from c38b5af to fa5c209 Compare March 4, 2025 09:21
@Pascal-Delange Pascal-Delange enabled auto-merge (rebase) March 4, 2025 09:21
@Pascal-Delange Pascal-Delange merged commit edb7e58 into main Mar 4, 2025
3 checks passed
@Pascal-Delange Pascal-Delange deleted the pascal/breaking-change-env-var-rename branch March 4, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants