feat: convert environment variable resource tests and fix behavior

internal/provider/resources/environment_variable_resource.go

@@ -267,10 +267,16 @@ func (m *EnvironmentVariableResourceModel) Refresh(ctx context.Context, from *ch
 	}
 
 	m.Key = types.StringValue(from.Key)
-	m.Value = types.StringValue(from.Value)
 	m.Locked = types.BoolValue(from.Locked)
 	m.Secret = types.BoolValue(from.Secret)
 
+	// We can never receive a secret value back from the server. Just assume
+	// the value is still unchanged and only update state if we're not dealing
+	// with a secret.
+	if !from.Secret {
+		m.Value = types.StringValue(from.Value)
+	}
+
 	return nil
 }
 

internal/provider/resources/environment_variable_resource_test.go

@@ -0,0 +1,70 @@
+package resources_test
+
+import (
+	"regexp"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+)
+
+func TestAccEnvVarCheckRequiredFields(t *testing.T) {
+	config := `resource "checkly_environment_variable" "test" {}`
+	resource.UnitTest(t, resource.TestCase{
+		ProtoV6ProviderFactories: protoV6ProviderFactories(),
+
+		Steps: []resource.TestStep{
+			{
+				Config:      config,
+				ExpectError: regexp.MustCompile(`The argument "key" is required`),
+			},
+			{
+				Config:      config,
+				ExpectError: regexp.MustCompile(`The argument "value" is required`),
+			},
+		},
+	})
+}
+
+func TestAccEnvVarSuccess(t *testing.T) {
+	config := `resource "checkly_environment_variable" "test" {
+		key     = "API_URL"
+		value   = "https://api.checklyhq.com"
+	}`
+	resource.UnitTest(t, resource.TestCase{
+		ProtoV6ProviderFactories: protoV6ProviderFactories(),
+
+		Steps: []resource.TestStep{
+			{
+				Config: config,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(
+						"checkly_environment_variable.test",
+						"key",
+						"API_URL",
+					),
+					resource.TestCheckResourceAttr(
+						"checkly_environment_variable.test",
+						"value",
+						"https://api.checklyhq.com",
+					),
+				),
+			},
+		},
+	})
+}
+
+func TestAccSecretEnvVarSuccess(t *testing.T) {
+	resource.UnitTest(t, resource.TestCase{
+		ProtoV6ProviderFactories: protoV6ProviderFactories(),
+
+		Steps: []resource.TestStep{
+			{
+				Config: `resource "checkly_environment_variable" "test" {
+				key     = "SECRET"
+				value   = "https://api.checklyhq.com"
+				secret  = true
+			}`,
+			},
+		},
+	})
+}