This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Bug: togglePause on re-opening popup fixed #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state did not load correctly after closing the popup and re-opening it again. The state would instead be the default state (isPaused=false) because the state was saved to _isPaused, which is wrong! After removing the lowdash and saving the state back to the actual state isPaused the pause-button is working again correctly.
Pull Request Template
Description
Please include a summary of the change or which issue is fixed. Also, include relevant motivation and context.
Remember, as mentioned in the contribution guidelines that
PR's should be as atomic as possible 1 feature === 1 PR. 1 bugfix === 1 PR.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist:
npm run lint
passes with no errors.npm run test
passes with no errors.