Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Bug: togglePause on re-opening popup fixed #53

Merged
merged 1 commit into from
May 13, 2019
Merged

Bug: togglePause on re-opening popup fixed #53

merged 1 commit into from
May 13, 2019

Conversation

DennisLoska
Copy link
Contributor

@DennisLoska DennisLoska commented May 9, 2019

The state did not load correctly after closing the popup and re-opening it again. The state would instead be the default state (isPaused=false) because the state was saved to _isPaused, which is wrong! After removing the lowdash and saving the state back to the actual state isPaused the pause-button is working again correctly.

Pull Request Template

Description

Please include a summary of the change or which issue is fixed. Also, include relevant motivation and context.
Remember, as mentioned in the contribution guidelines that
PR's should be as atomic as possible 1 feature === 1 PR. 1 bugfix === 1 PR.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project. npm run lint passes with no errors.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. npm run test passes with no errors.

The state did not load correctly after closing the popup and re-opening it again. The state would instead be the default state (isPaused=false) because the state was saved to _isPaused, which is wrong! After removing the lowdash and saving the state back to the actual state isPaused the pause-button is working again correctly.
@tnolet
Copy link
Member

tnolet commented May 10, 2019

Hey @DennisLoska thanks for contributing! I will check this after the weekend!

@DennisLoska
Copy link
Contributor Author

@tnolet I literally just changed one character, but feel free checking :D

@tnolet
Copy link
Member

tnolet commented May 13, 2019

LGMT

@tnolet tnolet merged commit 6e7c473 into checkly:develop May 13, 2019
@DennisLoska DennisLoska deleted the patch-1 branch May 13, 2019 10:05
@tnolet
Copy link
Member

tnolet commented May 13, 2019

@DennisLoska I just published v0.5.3 to the Chrome Store. This contains your fix. Thanks again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants