Bind array and function-typed compound literals to temporaries #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
June 29, 2020 13:26
…into issue-859-address-compound-literal
added 2 commits
July 6, 2020 20:45
dtarditi
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Looks great.
Does it make sense to add a test case to the checkedc repo to illustrate that the probem in #856 is fixed? The Checked C repo has tests for language-level behavior, while the checkedc-clang repo has tests that may expose compiler implementation details.
kkjeer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #859 - this PR will fix the issue for array-typed compound literals (but not for struct-typed compound literals - that is a follow-up issue, see issue #870)
This PR introduces a temporary binding for an array-typed or function-typed CompoundLiteralExpr. This allows the bounds checker to infer lvalue bounds for an array-typed compound literal in
CheckTempBindingLValue.Issue #870 tracks the work needed to bind non-array, non-function-typed compound literals to temporaries (e.g. struct-typed compound literals).
Testing: