Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checked information for compound statements to AST reading/writing #716

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

kkjeer
Copy link
Contributor

@kkjeer kkjeer commented Nov 5, 2019

(Issue #419): Modify ASTWriterStmt and ASTReaderStmt to write/read the checked scope specifier and written checked scope specifier for compound statements.

Future work: add checked information for function declarations to ASTWriterDecl and ASTReaderDecl (see issue #704).

Testing:

  • Added pch testing that checks the AST output of compound statements with checked information (using the -ast-dump-all option to dump the AST of the precompiled header).
  • Passed local testing on Windows.
  • Passed automated testing on Windows/Linux.

@kkjeer kkjeer requested review from dtarditi and mgrang November 5, 2019 00:34
Copy link
Member

@dtarditi dtarditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! The pch tests probably need to moved to a subdirectory. That can be done separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants