This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Khatchig - CEM2662 - Typing animation #440
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Khachig
commented
Jan 22, 2022
•
Khachig
commented
|
Attach a video gif to the pr |
ralph-dev
suggested changes
Jan 22, 2022
| <TextBubble {...args} /> | ||
| ); | ||
|
|
||
| export const Basic = Template.bind({}); |
Comment on lines
12
to
13
| <BubbleContainer fromBot={ fromBot }> | ||
| <Bubble fromBot={ fromBot }> |
Comment on lines
14
to
19
| <div style={{ | ||
| marginLeft: textMarginSize, | ||
| marginRight: textMarginSize, | ||
| display: "flex", | ||
| flexDirection: "row" | ||
| }}> |
Comment on lines
27
to
29
| const textMarginSize = "10px"; | ||
|
|
||
| const container_margin = "10px"; |
There was a problem hiding this comment.
Why are you defining margins inside the component?
Comment on lines
+11
to
+15
| let dots = []; | ||
|
|
||
| for (let i = 0; i < num; i ++) { | ||
| dots.push(<Dot delay={i * delayStep} />); | ||
| } |
ralph-dev
reviewed
Jan 22, 2022
Comment on lines
50
to
51
| marginTop: standardMarginSize; | ||
| margin-top: -20px; |
ralph-dev
reviewed
Jan 22, 2022
| return ( | ||
| <BubbleContainer fromBot={ fromBot }> | ||
| <Bubble fromBot={ fromBot }> | ||
| <div style={{ |
There was a problem hiding this comment.
{...bubbleDivProps} or {...bubbleDivStyle}
ralph-dev
reviewed
Jan 22, 2022
|
|
||
| export interface ITextBubbleProps { | ||
| content: React.ReactElement; | ||
| fromBot: boolean; |
There was a problem hiding this comment.
bubbleProps: React.HTMLAttrs(ReactDivElemet)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.