Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

CEM-971 Content Component #149

Merged
merged 2 commits into from
Sep 14, 2020
Merged

CEM-971 Content Component #149

merged 2 commits into from
Sep 14, 2020

Conversation

Ampatte2
Copy link
Contributor

Adding content component from terminal to library.

There are issues with babel 7.8.6 as seen here storybookjs/storybook#10477 . Upgrading to babel 7.9.0.

Should this be a layout?

CEM-971 Content Component

Copy link
Member

@ralph-dev ralph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm I guess, missing withList = true case

withList?: boolean;
}

export const Content: React.FC<ContentProps> = ({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this scrollableListContent?

@Ampatte2
Copy link
Contributor Author

That makes more sense. What do you mean by withList true case, in the storybook?

@ralph-dev
Copy link
Member

That makes more sense. What do you mean by withList true case, in the storybook?

Nvm ignore that comment, I saw you added a Knob which is perfect

@Ampatte2 Ampatte2 merged commit 9b9b659 into v2 Sep 14, 2020
@Ampatte2 Ampatte2 deleted the CEM-971-Content-Component branch September 14, 2020 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants