chore: use maven instead of 'java -jar' to run sample #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svor
reviewed
Aug 11, 2022
|
Please fix your Signed-off-by email: |
|
@svor done with both your comments. |
svor
reviewed
Aug 15, 2022
There was a problem hiding this comment.
Commands work fin on y side.
I just have a problem with the debugger:
@vitaliy-guliy could you please verify if it's a problem with the command that runs the application in not debug mode or maybe it's more general problem and we need another issue for it.
|
It seems the debugger works fine with the old command, need to update a new one to make it possible to attach the debugger |
vitaliy-guliy
changed the title
|
@svor done with both your comments. |
vitaliy-guliy
changed the title
svor
reviewed
Aug 17, 2022
devfile.yaml
Outdated
| group: | ||
| kind: run | ||
| isDefault: true | ||
|
|
||
| - id: run-debug | ||
| - id: run-with-mysql-new |
There was a problem hiding this comment.
i think run-with-mysql would be better
There was a problem hiding this comment.
Yes, it's definitely better to use command name without new ending.
Thanks.
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
For commands to run sample, it's better to use
mvn spring-boot:runinstead ofjava -jarSolves eclipse-che/che#20791
To test use
https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/dashboard/#/https://github.com/vitaliy-guliy/java-spring-petclinic/tree/devfilev2&che-editor=che-incubator/che-code/insiders