Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license and removed wrong copyright header #5

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

tsmaeder
Copy link
Contributor

Fix for eclipse-che/che#14890

Signed-off-by: Thomas Mäder tmader@redhat.com

Signed-off-by: Thomas Mäder <tmader@redhat.com>
* Licensed under the MIT License. See LICENSE in the project root for license information.
*--------------------------------------------------------------------------------------------*/
using System;
using System;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should contains ASL header as well, no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the filed does not contain a license header in the original code. The ASL license states that we have to preserve existing headers and that we can add additional headers "for our modifications". Both do not apply here.

Copy link

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit.

@nickboldt nickboldt merged commit bee366c into master Oct 24, 2019
@svor svor deleted the 14890_fix_licensing branch February 4, 2020 14:20
gitbook-com bot pushed a commit to sweepingmonk123/dotnet-web-simple that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants