Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Configdump deployment on OpenShift #8

Merged
merged 7 commits into from
Aug 10, 2020

Conversation

skabashnyuk
Copy link
Collaborator

@skabashnyuk skabashnyuk commented Aug 6, 2020

What does this PR do?

  • Fixed incorrect label configuration. Replaced CM_LABELS with CONFIG_BUMP_LABELS
  • Added POD_NAME that is needed for main.go:leader.Become(context.Background(), controllerName) initialization
  • Added pod permissions (we can minimize this list later) for correct main.go:manager.New initialization`
  • Disabled metrics to avoid port conflicts manager.Options{MetricsBindAddress: "0", Namespace: namespace}
  • Added labels to configmap example

What issues does this PR fix or reference?

Fixes eclipse-che/che#17567

sparkoo
sparkoo previously approved these changes Aug 6, 2020
Copy link
Member

@sparkoo sparkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider moving the yaml content to extra file (deployment_example.yaml ?) and link it from README.md. It would be easier to copy/paste, reference, etc...

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sparkoo sparkoo dismissed their stale review August 7, 2020 07:22

some additional questions

skabashnyuk and others added 5 commits August 7, 2020 13:06
Co-authored-by: Michal Vala <michal.vala@gmail.com>
cmd/configbump/main.go Outdated Show resolved Hide resolved
@skabashnyuk skabashnyuk merged commit cfd8b24 into che-incubator:master Aug 10, 2020
@skabashnyuk skabashnyuk deleted the configbumpconfig branch August 10, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configubump tool produces incorrect configuration in some cases
2 participants