Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golden middle between che-operator dependencies and mature enough controller-runtime version #10

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

skabashnyuk
Copy link
Collaborator

@skabashnyuk skabashnyuk commented Aug 27, 2020

What does this PR do?

golden middle between che-operator dependencies and mature enough controller-runtime version
CQs TODO after that

Знімок екрана 2020-08-27 о 14 51 39

What issues does this PR fix or reference?

eclipse-che/che#17568

Copy link
Collaborator

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I promise to never use any new version of anything in Eclipse projects 😄 Thanks for sorting the mess..

pkg/configmaps/lib.go Show resolved Hide resolved
@skabashnyuk
Copy link
Collaborator Author

tests not working. Checking that ....

@skabashnyuk skabashnyuk changed the title Align dependencies with che-operator golden middle between che-operator dependencies and mature enough controller-runtime version Aug 28, 2020
@skabashnyuk
Copy link
Collaborator Author

tests are working

@skabashnyuk skabashnyuk merged commit ef4b882 into che-incubator:master Aug 31, 2020
@skabashnyuk skabashnyuk deleted the deps branch August 31, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants