Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete auth and workspace command groups #1910

Merged
merged 5 commits into from
Dec 24, 2021

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Dec 20, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

This PR deletes auth commands group from chectl due to switching to devworkspace engine (see eclipse-che/che-operator#1265) which doesn't use Keycloak any more where as commands from auth group expect to work with Keycloak. This cannot be fixed and should be re-implemented.
The same for workspace commands group as devworksapace is a different engine and old code should be rewritten (also workspace commands depend on auth commands).

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Is a part of eclipse-che/che#20671
Depends on: eclipse-che/che-operator#1265

How to test this PR?

N/A code removal, all tests should pass

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha changed the title Delete auth and workspace command groups chore: Delete auth and workspace command groups Dec 24, 2021
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Dec 24, 2021

@mmorhun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v9-chectl-e2e-rollback f699036 link true /test v9-chectl-e2e-rollback
ci/prow/v8-chectl-e2e-rollback f699036 link true /test v8-chectl-e2e-rollback

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 78565e0 into main Dec 24, 2021
@tolusha tolusha deleted the che-20671-delete-auth-and-ws-commands branch December 24, 2021 12:23
@che-bot che-bot added this to the 7.42 milestone Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants