Read user namespace from file #97
Conversation
|
It might be a bit hard to test this PR at the moment since we do not have a devfile v2 yet (issue). In general, the steps here from the docs can be followed. Unlike what's mentioned in the docs, we don't need a Additionally, if there's already a default telemetry plugin listening on port 4167, the default telemetry plugin should first be removed before testing this PR. This is because running this project also requires listening on port 4167. |
| private String getCurrentNamespace(KubernetesClient client) throws IOException { | ||
| BufferedReader br = new BufferedReader(new FileReader(Config.KUBERNETES_NAMESPACE_PATH)); | ||
| String namespace = br .readLine(); | ||
| br.close(); | ||
| return namespace.strip(); | ||
| } |
There was a problem hiding this comment.
got a bit lost with implementation. Why do we pass the client in param? also wondering if it is a reliable way of getting the namespace based on the KUBERNETES_NAMESPACE_PATH ? should not we close reader in finally?
There was a problem hiding this comment.
Oops, thank you for pointing that out.
As for whether getting the namespace based on the KUBERNETES_NAMESPACE_PATH is reliable, it seems to work well empirically, but are there cases where /var/run/secrets/kubernetes.io/serviceaccount is not mounted to the container?
I've updated the code so that there is a new approach as well as the file reading approach. The new approach is reading the DEVWORKSPACE_NAMESPACE environment variable set on the workspace containers by the DWO
dkwon17
force-pushed
the
readnamespacefromfile
branch
3 times, most recently
from
0fc3132
to
fed60f4
Compare
Signed-off-by: David Kwon <dakwon@redhat.com>
dkwon17
force-pushed
the
readnamespacefromfile
branch
from
fed60f4
to
25fb30f
Compare
Reads the current namespace from
/var/run/secrets/kubernetes.io/serviceaccount/namespace.Fixes #92.
Signed-off-by: David Kwon dakwon@redhat.com