Fix rounding issue when parsing CPU k8s resources #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take floor before returning a CPU resource in millis to avoid invalid values resulting from floating point precision (4.0+0.03)*1000 !== 4030 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
azatsarynnyy and
RomanNikitenko
as code owners
azatsarynnyy
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue where adding Kubernetes resource units results in invalid values:
returns
4030.0000000000005mWhat issues does this PR fix?
Part of eclipse-che/che#21811
How to test this PR?
k8sUnits.sumUnits("4000m", "30m", "cpu")should return4030m