Set the workspace folder on server start #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azatsarynnyy
changed the title
benoitf
approved these changes
Oct 19, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets the folder that VS Code should open by default.
When VS Code server starts, we provided it with
${PROJECT_SOURCE}environment variable value as the--default-folder.When the user's browser loads frontend, it receives that value as part of the workbench web configuration. Then, VS Code opens the corresponding folder. So, no need to load VS Code twice (as it used to be) to detect (on the first load) the folder that needs to be opened.
What issues does this PR fix or reference?
eclipse-che/che#21400 and possibly eclipse-che/che#21392
How to test this PR?