-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace asyncio-redis with redis-py #867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our connection can die somehow without us knowing, which will hang the worker.
I looked through the asyncio code and audited the timeouts
sbdchd
reviewed
Feb 4, 2023
sbdchd
reviewed
Feb 4, 2023
sbdchd
reviewed
Feb 4, 2023
sbdchd
reviewed
Feb 4, 2023
sbdchd
reviewed
Feb 4, 2023
Co-authored-by: Steve Dignam <steve@dignam.xyz>
sbdchd
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asyncio-redis is pretty terrible in adverse network conditions. Digital Ocean network connectivity can flake out and the lack of timeouts within asyncio-redis make it easy for the library to cause hangs, which will break Kodiak for users. redis-py's async version (which originally was aioredis) has excellent timeouts for every operation, making it a safer choice. It also has a reasonable connection pool setup where we don't need to have a fixed pool size.
The default timeouts for redis-py async are infinite, which isn't great, but we explicitly set short timeouts.
Hopefully, now we shouldn't see any more hangs, which has been a problem for us for many months.