Introduce approve.auto_approve_labels option
#817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ignore comment to correct line: > kodiak/test_queries.py:228: error: unused 'type: ignore' comment > kodiak/test_queries.py:230: error: The return type of an async generator function should be "AsyncGenerator" or one of its supertypes [misc] Update sentry-sdk to fix the following errors (see getsentry/sentry-python#1421): > ************* Module kodiak.logging > kodiak/logging.py:139:4: E0110: Abstract class 'init' with abstract methods instantiated (abstract-class-instantiated) > ************* Module kodiak.refresh_pull_requests > kodiak/refresh_pull_requests.py:34:0: E0110: Abstract class 'init' with abstract methods instantiated (abstract-class-instantiated) > kodiak/refresh_pull_requests.py:44:0: E0110: Abstract class 'init' with abstract methods instantiated (abstract-class-instantiated)
- Add python extensions to recommendations
- Support for nose tests ('nosetestsEnabled') has been removed,
see microsoft/vscode-python#16371
- 'pythonPath' has been replaced by 'defaultInterpreterPath',
see https://github.com/microsoft/vscode-python/wiki/AB-Experiments#tldr
Fixes the following error from mypy: > kodiak/evaluation.py:784:12: error: Module has no attribute "exceptions" [attr-defined]
👷 Deploy request for kodiak-docs pending review.Visit the deploys page to approve it
|
👷 Deploy request for kodiak-dashboard-staging pending review.Visit the deploys page to approve it
|
8 tasks
|
Thanks for the PR @paescuj! This looks great. Thanks for the documentation and tests. I'll look into merging this soon |
|
Thanks for the fast & positive feedback, @chdsbd! That's great! |
Apparently this works with Python3.7 but not with Python3.9 (which I had installed on my end)
chdsbd
approved these changes
Jun 9, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554
Implemented as suggested by @chdsbd:
Also fixing some lint errors & enhances developer experience (see commits).