feat(notifications): missing branch protection notifications

kodiak/evaluation.py

@@ -1,6 +1,7 @@
 import re
 import typing
 from collections import defaultdict
+from typing import Optional
 
 import structlog
 
@@ -100,7 +101,7 @@ def review_status(reviews: typing.List[PRReview]) -> PRReviewState:
 def mergeable(
     config: config.V1,
     pull_request: PullRequest,
-    branch_protection: BranchProtectionRule,
+    branch_protection: Optional[BranchProtectionRule],
     review_requests_count: int,
     reviews: typing.List[PRReview],
     contexts: typing.List[StatusContext],
@@ -125,6 +126,11 @@ def mergeable(
     if config.app_id is not None and config.app_id != app_id:
         raise MissingAppID("missing required app_id")
 
+    if branch_protection is None:
+        raise NotQueueable(
+            f"missing branch protection for baseRef: {pull_request.baseRefName!r}"
+        )
+
     if config.merge.automerge_label not in pull_request.labels:
         raise NotQueueable(
             f"missing automerge_label: {repr(config.merge.automerge_label)}"

kodiak/queries.py

@@ -4,6 +4,7 @@
 from dataclasses import dataclass, field
 from datetime import datetime, timedelta, timezone
 from enum import Enum
+from typing import Optional
 
 import arrow
 import jwt
@@ -219,7 +220,7 @@ class EventInfoResponse:
     config: V1
     pull_request: PullRequest
     repo: RepoInfo
-    branch_protection: BranchProtectionRule
+    branch_protection: Optional[BranchProtectionRule]
     review_requests_count: int
     head_exists: bool
     reviews: typing.List[PRReview] = field(default_factory=list)
@@ -603,9 +604,6 @@ async def get_event_info(
         branch_protection = get_branch_protection(
             repo=repository, ref_name=pr.baseRefName
         )
-        if branch_protection is None:
-            log.warning("Could not find branch protection")
-            return None
 
         return EventInfoResponse(
             config=config,

kodiak/test_evaluation.py

@@ -132,7 +132,7 @@ def test_blacklist_title_match(
     context: StatusContext,
 ) -> None:
     # a PR with a blacklisted title should not be mergeable
-    with pytest.raises(NotQueueable, match="blacklist_title"):
+    with pytest.raises(NotQueueable, match="blacklist_title") as e_info:
         config.merge.blacklist_title_regex = "^WIP:.*"
         pull_request.title = "WIP: add fleeb to plumbus"
         mergeable(
@@ -146,6 +146,7 @@ def test_blacklist_title_match(
             valid_signature=False,
             valid_merge_methods=[MergeMethod.merge, MergeMethod.squash],
         )
+    assert config.merge.blacklist_title_regex in str(e_info.value)
 
 
 def test_bad_merge_method_config(
@@ -892,3 +893,23 @@ def test_merge_state_status_draft(
             valid_signature=False,
             valid_merge_methods=[MergeMethod.squash],
         )
+
+
+def test_missing_branch_protection(pull_request: PullRequest, config: V1) -> None:
+    """
+    We don't want to do anything if branch protection is missing
+    """
+
+    branch_protection = None
+    with pytest.raises(NotQueueable, match="missing branch protection"):
+        mergeable(
+            config=config,
+            pull_request=pull_request,
+            branch_protection=branch_protection,
+            review_requests_count=0,
+            reviews=[],
+            contexts=[],
+            check_runs=[],
+            valid_signature=False,
+            valid_merge_methods=[MergeMethod.squash],
+        )