Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bot): optionally strip the cut separator #771

Merged
merged 2 commits into from
Dec 25, 2021
Merged

feat(bot): optionally strip the cut separator #771

merged 2 commits into from
Dec 25, 2021

Conversation

jbergstroem
Copy link
Contributor

@jbergstroem jbergstroem commented Dec 20, 2021 •
edited
Loading

If cut_body_after or cut_body_before is in use, setting this option to True also strips the separator itself.

Note, this is a draft; awaiting the following input:

  1. Is there a better name? (renamed to cut_body_and_text)
  2. Should we improve the way the body string is managed?
  3. json schema generation is having issues with REDISCLOUD_URL and SECRET_KEY

Fixes: #770

@netlify
Copy link

netlify bot commented Dec 20, 2021 •
edited
Loading

👷 Deploy request for kodiak-docs pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: f27416e

@netlify
Copy link

netlify bot commented Dec 20, 2021 •
edited
Loading

👷 Deploy request for kodiak-dashboard-staging pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: f27416e

@jbergstroem jbergstroem marked this pull request as draft December 20, 2021 21:57
@jbergstroem jbergstroem force-pushed the feat/strip-separator branch 2 times, most recently from ee488ef to 83a627f Compare December 20, 2021 22:06
@jbergstroem jbergstroem changed the title feat: optionally strip the cut separator feat(bot): optionally strip the cut separator Dec 20, 2021
chdsbd
chdsbd approved these changes Dec 21, 2021
View reviewed changes
Copy link
Owner

@chdsbd chdsbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great!

bot/kodiak/evaluation.py Outdated Show resolved Hide resolved
@chdsbd chdsbd added the automerge Mark PR for auto merge by Kodiak label Dec 21, 2021
@jbergstroem
feat: optionally strip body and text
f27416e 
If `cut_body_after` or `cut_body_before` is in use, setting this option
to `true` also removes the text itself.
@jbergstroem jbergstroem marked this pull request as ready for review December 21, 2021 12:03
@jbergstroem
Copy link
Contributor Author

@chdsbd could you enable the checks so we can see if it passes?

@kodiakhq kodiakhq bot merged commit 4c705ce into chdsbd:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chdsbd chdsbd chdsbd approved these changes

Assignees
No one assigned
Labels
automerge Mark PR for auto merge by Kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: option to remove separator as part of cutting body
2 participants
@jbergstroem @chdsbd