Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(notifications): improve github check messages for PR status #72

Merged
merged 6 commits into from
Jul 17, 2019
Merged

ref(notifications): improve github check messages for PR status #72

merged 6 commits into from
Jul 17, 2019

Conversation

chdsbd
Copy link
Owner

@chdsbd chdsbd commented Jul 17, 2019 •
edited
Loading

CHANGES

  • add message when PR is good to merge
  • reduce some duplicated logic in mergeability for set_status

BEFORE
Screen Shot 2019-07-17 at 7 22 52 PM
AFTER
Screen Shot 2019-07-17 at 7 21 24 PM

chdsbd added 4 commits July 17, 2019 19:10
@chdsbd
ref(notifications): add message for merging
e6f55f1 
CHANGES
- replace BaseException with Exception. BaseException is improper.
- reduce some duplicated logic in mergeability for set_status
@chdsbd
lint
c6ca1b8
@chdsbd
undo exception changes
f9a354b
@chdsbd
ref
3c818dc
@chdsbd chdsbd changed the title ref(notifications): add message for merging ref(notifications): improve github check messages for PR status Jul 17, 2019
@chdsbd chdsbd added the automerge Mark PR for auto merge by Kodiak label Jul 17, 2019
@kodiakhq kodiakhq bot merged commit dc370f1 into master Jul 17, 2019
@kodiakhq kodiakhq bot deleted the more-statuses branch July 17, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbdchd sbdchd sbdchd approved these changes

Assignees
No one assigned
Labels
automerge Mark PR for auto merge by Kodiak
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chdsbd @sbdchd