feat(bot): renovate auto merge support #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor refactor I pulled out of #713
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 22, 2021
This is a minor refactor I pulled out of #713
sbdchd
reviewed
Aug 24, 2021
| continue | ||
| match_type = _compare_versions(group["old_version"], group["new_version"]) | ||
| if not match_type: | ||
| continue |
There was a problem hiding this comment.
what about these codecov warnings?
chdsbd
commented
Aug 24, 2021
Comment on lines
+116
to
+117
| if "old_version" not in group or "new_version" not in group: | ||
| continue |
There was a problem hiding this comment.
@sbdchd I don't think we'll ever hit this code in reality, but I'm also not willing to assert on that
| continue | ||
| match_type = _compare_versions(group["old_version"], group["new_version"]) | ||
| if not match_type: | ||
| continue |
sbdchd
reviewed
Aug 24, 2021
| body: str | ||
|
|
||
|
|
||
| def generate_test_cases() -> Iterator[tuple[FakePR, str]]: |
sbdchd
reviewed
Aug 24, 2021
| @@ -0,0 +1,44 @@ | |||
| from __future__ import annotations | |||
|
|
|||
There was a problem hiding this comment.
should this test module be renamed to say "test_renovate.py` like the dependabot one?
There was a problem hiding this comment.
no, because this is general, testing both of them
sbdchd
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change supports auto merging Renovate PRs by update type.
related #701