Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login.tsx #1045

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Update login.tsx #1045

merged 4 commits into from
Jul 31, 2024

Conversation

nipunh
Copy link
Contributor

@nipunh nipunh commented Jul 19, 2024

Issue link / number:

#1044

What changes did you make?

Update the check requested in issue

Why did you make the changes?

if (partnerAdmin?.id) to if (partnerAdmin?.active)

Did you run tests?

No

@kyleecodes

Copy link

vercel bot commented Jul 19, 2024

@nipunh is attempting to deploy a commit to the Chayn Team on Vercel.

A member of the Team first needs to authorize it.

@nipunh nipunh closed this Jul 19, 2024
@nipunh nipunh reopened this Jul 19, 2024
@kyleecodes
Copy link
Member

Hi @nipunh thank you for your PR! Everything looks good. Just one thing, we need to run Cypress tests.
Are you able to run those tests? Directions are in the CYPRESS.md file.

@nipunh
Copy link
Contributor Author

nipunh commented Jul 23, 2024

Hi @nipunh thank you for your PR! Everything looks good. Just one thing, we need to run Cypress tests. Are you able to run those tests? Directions are in the CYPRESS.md file.

I was facing some problems with the backend setup and database seeding

Copy link
Member

@kyleecodes kyleecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nipunh understood. I ran the tests this time. Next time, let us know the problems you are facing so we can set you up.

The dependency array on line 92 also needs updated. Ill fix that then approve after tests pass.

@kyleecodes kyleecodes merged commit 82d7762 into chaynHQ:develop Jul 31, 2024
5 of 6 checks passed
Copy link

cypress bot commented Jul 31, 2024



Test summary

40 0 2 0


Run details

Project Bloom frontend
Status Passed
Commit 82d7762
Started Jul 31, 2024 12:21 AM
Ended Jul 31, 2024 12:29 AM
Duration 07:35 💡
OS Linux Ubuntu -
Browser Chrome 126

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants