Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes error with editor when --- is inserted #8669

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Conversation

nithindavid
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change and issue(s) fixed. Also, mention relevant motivation, context, and any dependencies that this change requires.
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@nithindavid nithindavid requested a review from iamsivin January 9, 2024 05:45
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for chatwoot-storybook canceled.

Name Link
🔨 Latest commit 721b5a8
🔍 Latest deploy log https://app.netlify.com/sites/chatwoot-storybook/deploys/659f9173cac7d400080871a7

package.json Outdated Show resolved Hide resolved
@nithindavid nithindavid marked this pull request as ready for review January 10, 2024 23:58
package.json Outdated Show resolved Hide resolved
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
yarn.lock Outdated Show resolved Hide resolved
Copy link
Member

@iamsivin iamsivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnu-narayanan vishnu-narayanan temporarily deployed to test-pipelin-fix-hr-edi-tgfkif January 11, 2024 07:18 Inactive
@nithindavid nithindavid merged commit 810f950 into develop Jan 11, 2024
19 checks passed
@nithindavid nithindavid deleted the fix/hr-editor branch January 11, 2024 15:56
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants