Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 93 #96

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Fix issue 93 #96

merged 3 commits into from
Jan 11, 2021

Conversation

karuppiah7890
Copy link
Contributor

Fixes #93

@karuppiah7890
use helm v3 library to load and package both helm v2 and helm v3 charts
039407a 
this reverts the golang code changes made in 17794c3
@karuppiah7890
[temp] upgrade helm v2 in test environment setup
c40f99d 
This is to avoid issues related to old stable repo which does not
exist and hence cannot be added during helm init
@karuppiah7890 karuppiah7890 mentioned this pull request Jan 3, 2021
Closed
@karuppiah7890
Copy link
Contributor Author

I think we will have to merge #95 first, which has fixed all the TLS certificate issues 😅

@karuppiah7890
Copy link
Contributor Author

In this PR I also temporarily updated helm v2 for the test setup

@karuppiah7890
Copy link
Contributor Author

Ideally it will be removed once we merge #95 . So, this PR is kind of dependent on #95

@jdolitsky jdolitsky merged commit 985cc78 into chartmuseum:master Jan 11, 2021
@karuppiah7890 karuppiah7890 deleted the fix-issue-93 branch January 12, 2021 08:28
@karuppiah7890
Copy link
Contributor Author

@jdolitsky Maybe we could add a test for this? In the mock data of the acceptance tests. I didn't think of that and missed it. Mock chart with some mixed API versions

v1 chart > v2 chart > v1 chart
v2 chart > v1 chart > v2 chart

Since helm v2 is still in use by people, maybe it's good to add.

@karuppiah7890
Copy link
Contributor Author

I can create an issue to track it and then add it sometime. Let me know your thoughts

@karuppiah7890
Copy link
Contributor Author

We would have to add appropriate test data. The above is just the first thing that came to my mind

@jdolitsky
Copy link
Contributor

@karuppiah7890 - sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm push with error when subchart using apiVerion v2
2 participants
@karuppiah7890 @jdolitsky