Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subscription sets [ch16280] #55

Merged
merged 3 commits into from
Sep 23, 2019

Conversation

tommycarney
Copy link
Contributor

@tommycarney tommycarney commented Sep 23, 2019

This PR allows for support for subscription sets for the 1.x branch. It adds a subscription_set_external_id attribute to the following objects:

  • ChartMogul\LineItems
  • ChartMogul\Subscription

@pkopac
Copy link
Contributor

pkopac commented Sep 23, 2019

@tommycarney pls check out the build failures.

@tommycarney tommycarney force-pushed the tc/ch16280/support-subscription-sets branch from 1a5b59a to 610874a Compare September 23, 2019 14:09
@tommycarney
Copy link
Contributor Author

@pkopac from what I can see Travis now uses a new default build, meaning the php 5.5 install fails.

This issue is resolved if we set the distribution to trusty in the .travis.yml file.

When I do this, the nightly build fails because of the composer.json requirements don’t match.

It will work, however, when I add this snippet from master to .travis.yml to force it to ignore the restrictions:

  - |
    if [[ "$TRAVIS_PHP_VERSION" == 'nightly' ]]; then
      #ignore php version check on nightly build
      composer install --ignore-platform-reqs
    else
      composer install
    fi

@tommycarney tommycarney requested a review from pkopac September 23, 2019 14:24
@pkopac pkopac merged commit f074230 into 1.x Sep 23, 2019
@pkopac pkopac deleted the tc/ch16280/support-subscription-sets branch September 23, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants