Return annotation fix & return type (#57)

chartmogul · Nov 4, 2019 · af722d5 · af722d5
1 parent 0182b72
commit af722d5
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Customer.php b/src/Customer.php
@@ -99,9 +99,9 @@ public function customAttributes()
     /**
      * Find a Customer by External ID. Returns only first result!
      * @param string $externalId
-     * @return Customer
+     * @return Customer|null
      */
-    public static function findByExternalId($externalId)
+    public static function findByExternalId($externalId): ?Customer
     {
         if (gettype($externalId) == 'string') {
             $externalId = ['external_id' => $externalId];
@@ -111,9 +111,9 @@ public static function findByExternalId($externalId)
 
         if (is_null($response)) {
             return null;
-        } else {
-            return $response->first();
         }
+
+        return $response->first();
     }
 
     /**