Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the boot to chartjs-adapter-moment #7155

Merged
merged 6 commits into from
Feb 28, 2020
Merged

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Feb 25, 2020

No description provided.

@benmccann
Copy link
Contributor

benmccann commented Feb 25, 2020

Wow! I'm not sure what you changed to get it working that I didn't figure out, but glad you figured it out!

We should update the docs too. E.g. integration.md says "The date adapter for Moment.js is included with Chart.js, but you still need to include Moment.js itself if this is the date adapter you choose to use.". Should update the migration guide too

You can also update some of the comments in the time scale code: benmccann@e586f4e

@benmccann
Copy link
Contributor

I'm surprised you don't have to import chartjs-moment-adapter. How does it get pulled in and included?

karma.conf.js Show resolved Hide resolved
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may require website changes to ensure that the same files still work

benmccann
benmccann previously approved these changes Feb 25, 2020
Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked closer. The samples will need to be updated as they do not include any adapter, only moment. Perhaps we can use this as an opportunity to convert them to use luxon instead

@benmccann
Copy link
Contributor

benmccann commented Feb 25, 2020

It probably is a good idea to demonstrate something other than Moment. Luxon is more fully featured and has a better API and date-fns is smaller. Moment is rarely the best choice to use on the client side

Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks!

@etimberg etimberg added this to the Version 3.0 milestone Feb 28, 2020
@etimberg etimberg merged commit df3c73c into chartjs:master Feb 28, 2020
@kurkle kurkle deleted the boot-moment branch June 12, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants