Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak #7097

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix memory leak #7097

merged 1 commit into from
Feb 13, 2020

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Feb 13, 2020

References to charts are kept in Animator, so destroyed charts keep on hanging around.

50 times uPlot bench results in 580 MB retained memory, this PR drops it to 19 MB

@kurkle kurkle added this to the Version 3.0 milestone Feb 13, 2020
@etimberg etimberg merged commit 72c3c6d into chartjs:master Feb 13, 2020
@kurkle kurkle deleted the leak branch February 19, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants