Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isRadial is always false #7037

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fix isRadial is always false #7037

merged 1 commit into from
Jan 31, 2020

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jan 30, 2020 •
edited
Loading

This fixes the issues that TypeScript found in this file

src/core/core.controller.js(139,68): error TS2345: Argument of type 'IArguments' is not assignable to parameter of type 'any[]'.
src/core/core.controller.js(145,68): error TS2345: Argument of type 'IArguments' is not assignable to parameter of type 'any[]'.
src/core/core.controller.js(349,23): error TS2367: This condition will always return 'false' since the types '() => string' and 'string' have no overlap.

@benmccann benmccann mentioned this pull request Jan 30, 2020
Merged
@etimberg etimberg merged commit eec71bf into chartjs:master Jan 31, 2020
@etimberg etimberg added this to the Version 3.0 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @etimberg @kurkle