Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize on zoom #6974

Merged
merged 2 commits into from
Jan 18, 2020
Merged

Resize on zoom #6974

merged 2 commits into from
Jan 18, 2020

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Jan 17, 2020

When zooming, the dimensions stay the same, only devicePixelRatio changes.
Not sure what case this if was added originally for.

Fixes: #5485

benmccann
benmccann previously approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it was added as some sort of optimization. This might not be a bad one to have a test for in case someone tries to add back a similar optimization in the future

@etimberg etimberg merged commit 767ffc0 into chartjs:master Jan 18, 2020
@etimberg etimberg added this to the Version 3.0 milestone Jan 18, 2020
@emmcb emmcb mentioned this pull request Jan 19, 2020
Closed
@kurkle kurkle deleted the zoom-resize branch February 19, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

charts getting blurred when zooming out and then zooming back in
3 participants
@kurkle @benmccann @etimberg