-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow switching platforms #6964
Merged
etimberg
merged 8 commits into
chartjs:master
from
davidswinegar:dwinegar-allow-switching-platforms
Jan 26, 2020
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f8945ea
Allow switching platforms
davidswinegar 5335709
Switch to a per-chart platform
davidswinegar c005cad
Address comments
davidswinegar f9fd4bd
Fix tests
davidswinegar 4863ed3
Merge branch 'master' into dwinegar-allow-switching-platforms
davidswinegar 1c297ab
Make disableCSSInjection a global again
davidswinegar dc81c40
Update documentation
davidswinegar b2561d7
Minor fix
davidswinegar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
/** | ||
* Platform fallback implementation (minimal). | ||
* @see https://github.com/chartjs/Chart.js/pull/4591#issuecomment-319575939 | ||
*/ | ||
|
||
'use strict'; | ||
|
||
import BasePlatform from './platform.base'; | ||
|
||
/** | ||
* Platform class for charts without access to the DOM or to many element properties | ||
* This platform is used by default for any chart passed an OffscreenCanvas. | ||
* @extends BasePlatform | ||
*/ | ||
export default class BasicPlatform extends BasePlatform { | ||
acquireContext(item) { | ||
// To prevent canvas fingerprinting, some add-ons undefine the getContext | ||
// method, for example: https://github.com/kkapsner/CanvasBlocker | ||
// https://github.com/chartjs/Chart.js/issues/2807 | ||
return item && item.getContext && item.getContext('2d') || null; | ||
} | ||
} |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: trailing comma