Fix reference to distanceBetweenPoints #6962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
approved these changes
Jan 14, 2020
|
@benmccann thanks for responding so quickly! Is there additional work to get the custom tooltip callback working? Happy to help out if needed. |
|
Not that I'm aware of just to get it working (though I haven't tested). However, I think it could be made massively faster. The issue is that right now the chart is redrawn whenever you move the mouse. However, this doesn't really need to happen if you've disabled the built-in tooltip and are using a custom html tooltip. |
etimberg
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6960