Update documentation of order
#6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
approved these changes
Jan 3, 2020
| @@ -88,7 +88,7 @@ the color of the bars is generally set this way. | |||
| | ---- | ---- | |||
| | `clip` | How to clip relative to chartArea. Positive value allows overflow, negative value clips that many pixels inside chartArea. `0` = clip at chartArea. Clipping can also be configured per side: `clip: {left: 5, top: false, right: -2, bottom: 0}` | |||
| | `label` | The label for the dataset which appears in the legend and tooltips. | |||
| | `order` | The drawing order of dataset. Also affects order for stacking, tooltip, and legend. | |||
There was a problem hiding this comment.
personally I prefer the comma here, but just a matter of preference ;-)
There was a problem hiding this comment.
Omg, how did I manage not to know about Oxford comma before!?
This is just how lists are expected to be written in Finnish, and it looked wrong to me.
Its fine by me either way.
etimberg
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6888