Improve stacking performance and footprint #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Nov 18, 2019
| const dataset = me.getDataset(); | ||
| const xid = meta.xAxisID = dataset.xAxisID || getFirstScaleId(chart, 'x'); | ||
| const yid = meta.yAxisID = dataset.yAxisID || getFirstScaleId(chart, 'y'); | ||
| meta.xScale = me.getScaleForId(xid); |
There was a problem hiding this comment.
this is a really good idea!
There was a problem hiding this comment.
do you think we should store iScale and vScale here as well?
benmccann
reviewed
Nov 18, 2019
| const dataset = me.getDataset(); | ||
| const xid = meta.xAxisID = dataset.xAxisID || getFirstScaleId(chart, 'x'); | ||
| const yid = meta.yAxisID = dataset.yAxisID || getFirstScaleId(chart, 'y'); | ||
| meta.xScale = me.getScaleForId(xid); |
There was a problem hiding this comment.
do you think we should store iScale and vScale here as well?
|
Forgot to mention the leading idea: in |
|
Added vScale / iScale. Also replaced getMeta() with _cachedMeta. Updated bunch of |
benmccann
approved these changes
Nov 18, 2019
etimberg
approved these changes
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance
Master
PR
About ~200ms improvement overall in uPlot stacked (~950ms -> ~750ms).
Memory
Master
PR