Reduce object creation during parsing #6758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #6750, which does not move
_parsed
out ofmetaData
Removed
addElementAndReset
because of a bug.insertElements
was callingupdateElement
viaaddElementAndReset
and then calling_parse
. However,updateElement
assumes that the parsing has already happened, so these were happening in the wrong order. Also,_parse
assumes themetaData
is already created and stored, so there was no possible way to calladdElementAndReset
without causing issues. The code now calls these methods in the correct orderIt also renames
_val
to_parsed
in doughnut.