Performance improvements #6729
Merged
Performance improvements #6729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On the topic of simplifying paths, this algorithm works very well since it retains peaks in the data. I've implemented it before in JS and could easily render 200k points with real-time updates. The simple optimization is to have max 4 points per pixel, but there are a number of other optimizations that come in as well that can usually reduce that even further. |
etimberg
reviewed
Nov 11, 2019
kurkle
force-pushed
the
more-performance
branch
from
7486509
to
8515156
Compare
benmccann
reviewed
Nov 11, 2019
| @@ -48,6 +48,7 @@ class Line extends Element { | |||
| } | |||
|
|
|||
| if (me._loop) { | |||
| points = points.slice(); // clone array | |||
There was a problem hiding this comment.
great catch! I had noticed this clone taking awhile, but didn't see that we could move it to occur here
benmccann
approved these changes
Nov 11, 2019
etimberg
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of performance improvements (still using uPlot benchmark for testing)
Nearest mode: Start finding nearest items at the index linearly in the mouse position. Then look in both directions as long as distance decreases.I guess next major thing would be simplifying paths