Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support boundary filling modes in radialLinear scale #6281

Merged
merged 1 commit into from
May 21, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented May 16, 2019

In radar charts,

  • if a dataset doesn't have NaN value, the boundary filling mode option ('start, 'end', 'origin') makes no effect
  • if a dataset has NaN value, all boundary modes result in wrong charts

This PR adds support for those boundary filling modes to be consistent with line charts. If a scale has circular grid lines, the boundary will also be in a circular shape.

Master: https://jsfiddle.net/nagix/etkr9p0x/
Screen Shot 2019-05-16 at 11 32 10 PM

This PR: https://jsfiddle.net/nagix/onaq4hbm/
Screen Shot 2019-05-16 at 11 32 37 PM

Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonbrunel simonbrunel added this to the Version 2.9 milestone May 21, 2019
@simonbrunel simonbrunel merged commit cfcdccc into chartjs:master May 21, 2019
@nagix nagix deleted the issue-6281 branch May 21, 2019 16:59
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants