Call determineDataLimits only once #6256
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
determineDataLimits
is a very expensive call. We call it multiple times for each scale, but really only need to calculate it onceMy initial idea was that in creating the layout we should call
fit
most of the times andupdate
only once, but that proved very difficult. E.g. to fit the scale you need to create the labels, which means you need the format, which in the time scale means you need the unit, which means you need to know how many ticks there are. So the way things are structured right now you can't easily get around building the ticks multiple times. butdetermineDataLimits
is by far the most expensive part ofupdate
for both the time and linear scale that I've been testing with, so this is actually a really big win.