Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify time scale options in standard manner #6097

Merged
merged 4 commits into from
Apr 2, 2019

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Feb 28, 2019

It's difficult to write code that interfaces with the scale min and max options in a standard manner because the time scale puts the options in a different place than all the other scales, so everything has to be special cased to detect the time scale. This change allows reading from either the standard options.ticks location or the options.time location which this PR deprecates

src/scales/scale.time.js Outdated Show resolved Hide resolved
kurkle
kurkle previously approved these changes Mar 25, 2019
etimberg
etimberg previously approved these changes Mar 25, 2019
nagix
nagix previously approved these changes Mar 26, 2019
src/scales/scale.time.js Outdated Show resolved Hide resolved
src/scales/scale.time.js Outdated Show resolved Hide resolved
@benmccann benmccann dismissed stale reviews from nagix, etimberg, and kurkle via 244117f March 28, 2019 13:05
src/scales/scale.time.js Outdated Show resolved Hide resolved
@simonbrunel simonbrunel added this to the Version 2.9 milestone Apr 1, 2019
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @benmccann

exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants