Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate anchor #6038

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Fix duplicate anchor #6038

merged 2 commits into from
Feb 5, 2019

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Feb 1, 2019

Anchors aren't generated for h1 tags. I first tried configuring gitbook to generate anchors for h1 tags, but it was quite strange to have anchor tags generated for the page header, which is probably why the default does not include them. So instead I went through and changed all the single # tags that weren't the page header to ##, etc. as appropriate

In updating the installation page, I reordered a bit. It seemed useful for users to know which file to grab before they go to fetch it from a CDN. We only want to encourage selecting the build yourself when using a CDN because if you're using the package it should be selected for you using package.json's main attribute, so I moved it under the CDN section

Also, the link https://www.chartjs.org/docs/latest/charts/bar.html#dataset-properties does not work because there are two instances on the page and it always takes you to the first, so the duplicate anchor was removed as suggested by @simonbrunel

etimberg
etimberg previously approved these changes Feb 2, 2019
docs/charts/bar.md Outdated Show resolved Hide resolved
Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch for the root anchor, it should be only one # (h1) per page.

docs/getting-started/installation.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants