Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and minor doc issues #6020

Merged
merged 6 commits into from
Jan 29, 2019
Merged

Fix typos and minor doc issues #6020

merged 6 commits into from
Jan 29, 2019

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jan 28, 2019

Fix typos and minor issues making the doc more consistent.

@simonbrunel
Copy link
Member

Thanks @nagix for this cleanup work, I like when it's done in one go and consistently.

@nagix
Copy link
Contributor Author

nagix commented Jan 28, 2019

Maybe it’s good time to convert all the primitive data types to lower case as suggested in #5925 (comment).

@simonbrunel
Copy link
Member

I think I would try to follow the TypeScript Basic Types notations and Do's and Don'ts. If these conventions make sense for everyone, I agree it's the good time.

etimberg
etimberg previously approved these changes Jan 28, 2019
@nagix
Copy link
Contributor Author

nagix commented Jan 28, 2019

Added more fixes, coveted basic data types to lower case and introduced TypeScript's union type expression.

docs/charts/area.md Outdated Show resolved Hide resolved
docs/developers/axes.md Outdated Show resolved Hide resolved
docs/general/colors.md Outdated Show resolved Hide resolved
@simonbrunel simonbrunel added this to the Version 2.8 milestone Jan 28, 2019
@nagix
Copy link
Contributor Author

nagix commented Jan 29, 2019

Thanks for the comments. The suggested changes have been added.

@simonbrunel simonbrunel merged commit 0d01bcf into chartjs:master Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants