Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common logic for resolving element options #6005

Merged
merged 3 commits into from
Jan 29, 2019

Conversation

benmccann
Copy link
Contributor

No description provided.

src/controllers/controller.line.js Outdated Show resolved Hide resolved
src/controllers/controller.line.js Outdated Show resolved Hide resolved
src/controllers/controller.line.js Outdated Show resolved Hide resolved
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready IMO,
one line can be saved and I agree with @simonbrunel with the function names.

src/controllers/controller.line.js Outdated Show resolved Hide resolved
kurkle
kurkle previously approved these changes Jan 22, 2019
etimberg
etimberg previously approved these changes Jan 23, 2019
src/controllers/controller.line.js Outdated Show resolved Hide resolved
@simonbrunel simonbrunel added this to the Version 2.8 milestone Jan 23, 2019
@benmccann benmccann dismissed stale reviews from etimberg and kurkle via 624f206 January 23, 2019 15:52
Copy link
Contributor

@nagix nagix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of what I needed for #5621.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants